elmPackages.elm: fix build failure on darwin#315141
elmPackages.elm: fix build failure on darwin#315141turboMaCk merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
|
@sandydoo since this is touching Haskell modules (which is indeed the right way to do it!) I think we might need to first merge it to haskell-updates branch. @sternenseemann or would it be OK with you if we merge this patch directly to main? |
|
Oh, that did not do what I wanted 🤦 Let me fix this... |
|
gosh. Yeah now the diff is all the master commits that haskell-updates lack behind. Version control is fun. Maybe you can keep master as base for now. I think maybe @sternenseemann will be OK with us merging this to the master? I'm not sure about how many rebuilds that could cause. If not then maybe new branch based on haskell-updates and cherry-pick the comment on top of that? That's probably what I would do. |
turboMaCk
left a comment
There was a problem hiding this comment.
LGTM. There is just what seems to be easy to resolve conflict.
|
Waiting for the the latest branch to download 🙂 Sorry for the noise, everyone! |
|
Oh no worries at all. I'm so glad someone picked this up. I was afraid I will need to steal Mac from my GF and set nix and everything up myself. Thanks a lot for looking into this. Also... If you wish -- consider adding yourself to the maintainers of elm. It would be great to have someone with MacOS at hand there. It's important platform we need to keep supporting. |
Patches `crypton-x509-system` to use the full path to the `security` binary.
|
Managed to wrangle git. Should be good now.
Will do, thanks! |
|
This can't go to master due to the high amount of rebuilds. I'm also confused – weren't we supposed to be able to build security tool again? |
So this just applies the same workaround that was used for I can try out the security-tool approach |
|
Can we merge this? |
|
I think so. I think usually maintainer of haskell-updates does so but this is already open for some time. |
|
Successfully created backport PR for |
|
I'd still appreciate it if someone could look into packaging the tool properly so we can get rid of these unsatisfactory workarounds! |
Patches
crypton-x509-systemto use the full path to thesecuritybinary. Same asx509-system.Fixes #297775.
cc @domenkozar @turboMaCk
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.