Skip to content

e2fsprogs: apply patches to fix libblockdev#315051

Merged
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:e2fsprogs-libblockdev
May 27, 2024
Merged

e2fsprogs: apply patches to fix libblockdev#315051
alyssais merged 1 commit intoNixOS:stagingfrom
alyssais:e2fsprogs-libblockdev

Conversation

@alyssais
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Fixes: 7678769 ("e2fsprogs: 1.47.0 -> 1.47.1")
@alyssais alyssais requested review from 7c6f434c and yu-re-ka May 27, 2024 10:00
@alyssais alyssais mentioned this pull request May 27, 2024
13 tasks
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looksed at both patches. Semantically, nop with the extras for small time_t does look correct in the context (extra seems to be for the part that does not fit into u32, after all). LGTM code-wise.

@7c6f434c
Copy link
Member

@ofborg build libblockdev

@ofborg ofborg bot requested a review from edolstra May 27, 2024 11:42
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 27, 2024
@alyssais alyssais merged commit 9a21575 into NixOS:staging May 27, 2024
@alyssais alyssais deleted the e2fsprogs-libblockdev branch May 27, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants