Skip to content

openlp: init at 3.1.2#314882

Open
jorsn wants to merge 2 commits intoNixOS:masterfrom
jorsn:openlp
Open

openlp: init at 3.1.2#314882
jorsn wants to merge 2 commits intoNixOS:masterfrom
jorsn:openlp

Conversation

@jorsn
Copy link
Member

@jorsn jorsn commented May 26, 2024 •
edited
Loading

Description of changes

looking for additional maintainers: I don't use OpenLP any more. I can stay a maintainer and help with non-trivial updates, but it would be very helpful to have someone using it, who notices updates and breakages.

Things done

  • Built on platform(s)
    • x86_64-linux (NixOS)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/). Functinality tested:
    • songs
    • bible verses
    • pdfs
    • presentations via libreoffice
    • pictures
    • videos
    • custom slides
    • web remote
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jorsn
Copy link
Member Author

jorsn commented May 26, 2024 •
edited
Loading

I added the backport label because the old package was broken (#296477).

This did not show up in Hydra, since so far meta.hydraPlatforms = [ ] was set. I had thought that the package in lib.nix would be built, but I think it wasn't because it appears nowhere in nixpkgs, except as a passthrough of the frontend package.

Also, this breaks no other package.

@jorsn jorsn requested review from Stunkymonkey and mweinelt May 26, 2024 16:41
@jorsn
Copy link
Member Author

jorsn commented May 26, 2024

@Green-D-683 @matj1 I would also appreciate your reviews, even if I can't formally request them.
Since you use OpenLP (I assume), it would be of great help if you could test whether the application works. Especially the libreoffice integration could be fragile.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 26, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 26, 2024
@Stunkymonkey Stunkymonkey removed their request for review May 26, 2024 18:55
@nixos-discourse
Copy link

nixos-discourse commented May 26, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-overriding-python-library-in-nixos-home-manager/38042/2

@mweinelt mweinelt removed their request for review May 26, 2024 20:40
@nixos-discourse
Copy link

nixos-discourse commented May 26, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/openlp-update-to-3-1-2-looking-for-reviewers-and-co-maintainers/46034/1

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jul 31, 2024
Merged
13 tasks
@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

This will need rebasing for #330855. Good luck with getting a co‐maintainer on board; it would be good to see this actively maintained again!

@smancill smancill added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 21, 2024
@ghost ghost closed this Dec 19, 2024
@emilazy
Copy link
Member

emilazy commented Dec 27, 2024

@aucub Why did you close this?

@ghost ghost reopened this Dec 27, 2024
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md and removed backport release-24.05 labels Dec 31, 2024
@emilazy emilazy mentioned this pull request Jan 22, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md and removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 5, 2025
@wolfgangwalther wolfgangwalther changed the title openlp: 2.4.6 -> 3.1.2 openlp: init at 3.1.2 Jul 9, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 9, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure:OpenLP

5 participants

@jorsn @nixos-discourse @emilazy @smancill @wegank