rustc: Enable profiler on more platforms by Artturin · Pull Request #314832 · NixOS/nixpkgs

Artturin · 2024-05-26T11:50:21Z

remove the isRedox condition which was added because stdenv.isLinux uses hostPlatform, after specifying targetPlatform it's no longer necessary

For error[E0463]: can't find crate for 'profiler_builtins'
#266570
https://logs.ofborg.org/?key=nixos/nixpkgs.266570&attempt_id=450d0b18-fd6a-4c44-893d-30de5941b73f

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

alyssais · 2024-05-26T11:55:53Z

Wouldn't it be better to assume this works on all platforms except ones where we have a reason to think it doesn't, like Redox? On a platform it doesn't work on, it would be IMO less confusing to get an error about profiler_builtins not building than one about it being missing from the standard library.

alyssais · 2024-05-26T13:16:06Z

pkgs/development/compilers/rust/rustc.nix

These links in your commit message are great — but maybe they should be in a comment so they can easily be checked and updated?

alyssais

LGTM as long as OfBorg is happy.

Artturin · 2024-05-28T11:49:07Z

LGTM as long as OfBorg is happy.

Ofborg failed with a timeout in llvm.

Tried building on the build box but

rustc> Building bootstrap
rustc> Auto configuration failed
rustc> 8646315008:error:02FFF001:system library:func(4095):Operation not permitted:/AppleInternal/Library/BuildRoots/91a344b1-f985-11ee-b563-fe8bc7981bff/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/bio/bss_file.c:122:fopen('/private/etc/ssl/openssl.cnf', 'rb')
rustc> 8646315008:error:20FFF002:BIO routines:CRYPTO_internal:system lib:/AppleInternal/Library/BuildRoots/91a344b1-f985-11ee-b563-fe8bc7981bff/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/bio/bss_file.c:127:
rustc> 8646315008:error:0EFFF002:configuration file routines:CRYPTO_internal:system lib:/AppleInternal/Library/BuildRoots/91a344b1-f985-11ee-b563-fe8bc7981bff/Library/Caches/com.apple.xbs/Sources/libressl/libressl-3.3/crypto/conf/conf_def.c:202:
rustc> failed to run: /nix/store/d4ih07nvbvvrhgsyxgy4in0b4q220wcl-cargo-bootstrap-1.76.0/bin/cargo build --manifest-path /private/tmp/nix-build-rustc-1.77.2.drv-0/rustc-1.77.2-src/src/bootstrap/Cargo.toml --frozen
rustc> Build completed unsuccessfully in 0:00:00
rustc> make: *** [Makefile:19: all] Error 1

Error happens without this pr too (nix build ".#rustc.unwrapped" --rebuild)

nix-community/infra#1289

Artturin · 2024-05-28T14:24:21Z

Compiling profiler_builtins v0.0.0 (/private/tmp/nix-build-rustc-1.77.2.drv-0/rustc-1.77.2-src/library/profiler_builtins)
The following warnings were emitted during compilation:

warning: [email protected]: clang-16: warning: argument unused during compilation: '-mmacos-version-min=11.0' [-Wunused-command-line-argument]
warning: [email protected]: clang-16: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
warning: [email protected]: error: unknown target CPU 'apple-a13'
warning: [email protected]: note: valid target CPU values are: mvp, bleeding-edge, generic

error: failed to run custom build command for `profiler_builtins v0.0.0 (/private/tmp/nix-build-rustc-1.77.2.drv-0/rustc-1.77.2-src/library/profiler_builtins)`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-rustc-1.77.2.drv-0/rustc-1.77.2-src/build/aarch64-apple-darwin/stage2-std/release/build/profiler_builtins-15fb419c8ddde0e8/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=LLVM_PROFILER_RT_LIB
  TARGET = Some("wasm32-unknown-unknown")
  OPT_LEVEL = Some("3")
  HOST = Some("aarch64-apple-darwin")
  cargo:rerun-if-env-changed=CC_wasm32-unknown-unknown
  CC_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CC_wasm32_unknown_unknown
  CC_wasm32_unknown_unknown = Some("clang")
  cargo:rerun-if-env-changed=CFLAGS_wasm32-unknown-unknown
  CFLAGS_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32_unknown_unknown
  CFLAGS_wasm32_unknown_unknown = Some("-ffunction-sections -fdata-sections -fPIC --target=wasm32-unknown-unknown")
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  running: "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "../../src/llvm-project/compiler-rt/include" "-fno-builtin" "-fomit-frame-pointer" "-fvis>
  cargo:warning=clang-16: warning: argument unused during compilation: '-mmacos-version-min=11.0' [-Wunused-command-line-argument]
  cargo:warning=clang-16: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
  cargo:warning=error: unknown target CPU 'apple-a13'
  cargo:warning=note: valid target CPU values are: mvp, bleeding-edge, generic
  exit status: 1

  --- stderr


  error occurred: Command "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=wasm32-unknown-unknown" "-I" "../../src/llvm-project/compiler-rt/include" "-fno-builtin" "-fomit-frame->


warning: build failed, waiting for other jobs to finish...

Artturin · 2024-09-17T22:07:50Z

Been a few months so retrying.

Artturin · 2024-09-19T16:12:03Z

New errors

Compiling profiler_builtins v0.0.0 (/private/tmp/nix-build-rustc-1.80.1.drv-0/rustc-1.80.1-src/library/profiler_builtins)
The following warnings were emitted during compilation:

warning: [email protected]: clang-16: warning: argument unused during compilation: '-mmacos-version-min=11.0' [-Wunused-command-line-argument]
warning: [email protected]: clang-16: warning: argument unused during compilation: '-arch arm64' [-Wunused-command-line-argument]
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:24:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/errno.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/errno.h:72:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/cdefs.h:828:2: error: Unsupported architecture
warning: [email protected]: #error Unsupported architecture
warning: [email protected]:  ^
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:25:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/fcntl.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/fcntl.h:78:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:33:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/machine/_types.h:36:2: error: architecture not supported
warning: [email protected]: #error architecture not supported
warning: [email protected]:  ^
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:25:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/fcntl.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/fcntl.h:78:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:55:9: error: unknown type name '__int64_t'; did you mean '__int>
warning: [email protected]: typedef __int64_t       __darwin_blkcnt_t;      /* total blocks */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:56:9: error: unknown type name '__int32_t'; did you mean '__int>
warning: [email protected]: typedef __int32_t       __darwin_blksize_t;     /* preferred block size */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:57:9: error: unknown type name '__int32_t'; did you mean '__int>
warning: [email protected]: typedef __int32_t       __darwin_dev_t;         /* dev_t */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:60:9: error: unknown type name '__uint32_t'; did you mean '__ui>
warning: [email protected]: typedef __uint32_t      __darwin_gid_t;         /* [???] process and group IDs */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:61:9: error: unknown type name '__uint32_t'; did you mean '__ui>
warning: [email protected]: typedef __uint32_t      __darwin_id_t;          /* [XSI] pid_t, uid_t, or gid_t*/
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:62:9: error: unknown type name '__uint64_t'; did you mean '__ui>
warning: [email protected]: typedef __uint64_t      __darwin_ino64_t;       /* [???] Used for 64 bit inodes */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:68:9: error: unknown type name '__darwin_natural_t'
warning: [email protected]: typedef __darwin_natural_t __darwin_mach_port_name_t; /* Used by mach */
warning: [email protected]:         ^
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:70:9: error: unknown type name '__uint16_t'; did you mean '__ui>
warning: [email protected]: typedef __uint16_t      __darwin_mode_t;        /* [???] Some file attributes */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:71:9: error: unknown type name '__int64_t'; did you mean '__int>
warning: [email protected]: typedef __int64_t       __darwin_off_t;         /* [???] Used for file sizes */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:72:9: error: unknown type name '__int32_t'; did you mean '__int>
warning: [email protected]: typedef __int32_t       __darwin_pid_t;         /* [???] process and group IDs */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:73:9: error: unknown type name '__uint32_t'; did you mean '__ui>
warning: [email protected]: typedef __uint32_t      __darwin_sigset_t;      /* [???] signal set */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:74:9: error: unknown type name '__int32_t'; did you mean '__int>
warning: [email protected]: typedef __int32_t       __darwin_suseconds_t;   /* [???] microseconds */
warning: [email protected]:         ^
warning: [email protected]: note: '__int128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:75:9: error: unknown type name '__uint32_t'; did you mean '__ui>
warning: [email protected]: typedef __uint32_t      __darwin_uid_t;         /* [???] user IDs */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types.h:76:9: error: unknown type name '__uint32_t'; did you mean '__ui>
warning: [email protected]: typedef __uint32_t      __darwin_useconds_t;    /* [???] microseconds */
warning: [email protected]:         ^
warning: [email protected]: note: '__uint128_t' declared here
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:25:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/fcntl.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/fcntl.h:83:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types/_size_t.h:31:9: error: unknown type name '__darwin_size_t'
warning: [email protected]: typedef __darwin_size_t        size_t;
warning: [email protected]:         ^
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:25:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/fcntl.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/fcntl.h:358:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types/_timespec.h:31:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/machine/types.h:39:2: error: architecture not supported
warning: [email protected]: #error architecture not supported
warning: [email protected]:  ^
warning: [email protected]: In file included from ../../src/llvm-project/compiler-rt/lib/profile/GCDAProfiling.c:25:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/fcntl.h:23:
warning: [email protected]: In file included from /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/fcntl.h:358:
warning: [email protected]: /nix/store/apgxk5abmyyc4b8xydd5ghf4fpb5shkl-libSystem-11.0.0/include/sys/_types/_timespec.h:35:2: error: unknown type name '__darwin_time_t'
warning: [email protected]:         __darwin_time_t tv_sec;
warning: [email protected]:         ^
warning: [email protected]: fatal error: too many errors emitted, stopping now [-ferror-limit=]
warning: [email protected]: 20 errors generated.

error: failed to run custom build command for `profiler_builtins v0.0.0 (/private/tmp/nix-build-rustc-1.80.1.drv-0/rustc-1.80.1-src/library/profiler_builtins)`

Artturin · 2024-09-19T16:18:00Z

Split out the stdenv.targetPlatform.isLinux fix. #343059

Sources for the conditionals https://www.github.com/rust-lang/rust/blob/master/src/ci/github-actions/jobs.yml https://www.github.com/rust-lang/rust/blob/5fe554350208b72cb8b66ce39bf0b92b1bba6edd/src/ci/docker/host-x86_64/dist-x86_64-freebsd/Dockerfile#L41 https://www.github.com/search?q=repo%3Arust-lang%2Frust%20%2Fenable-profiler%2F&type=code MinGW excluded because there's an open pr to rust to remove it's `enable-profiler` in `jobs.yml` https://www.github.com/rust-lang/rust/pull/122613/files

Artturin requested review from Mic92, figsoda, winterqt and zowoq as code owners May 26, 2024 11:50

ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 26, 2024

github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label May 26, 2024

Artturin force-pushed the rustcprofiler branch from 4db1b95 to bd23a80 Compare May 26, 2024 11:53

ofborg bot requested a review from tjni May 26, 2024 12:41

Artturin force-pushed the rustcprofiler branch 2 times, most recently from 34dafe9 to 5b7f605 Compare May 26, 2024 13:14

alyssais reviewed May 26, 2024

View reviewed changes

Artturin force-pushed the rustcprofiler branch from 5b7f605 to feb77a1 Compare May 26, 2024 13:28

alyssais approved these changes May 26, 2024

View reviewed changes

Artturin marked this pull request as draft May 28, 2024 14:30

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024

Artturin force-pushed the rustcprofiler branch from feb77a1 to ba7c386 Compare September 17, 2024 22:07

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 18, 2024

Artturin changed the title ~~rustc: Enable profiler on darwin~~ rustc: Enable profiler on more platforms Sep 19, 2024

Artturin mentioned this pull request Sep 19, 2024

rustc: Correct enable-profiler linux check #343059

Merged

13 tasks

Artturin force-pushed the rustcprofiler branch from ba7c386 to 07695c0 Compare September 24, 2024 16:14

Artturin closed this Sep 24, 2024

This was referenced Nov 1, 2024

rustc: Enable profiling support for Darwin builds #260725

Closed

Enable profiler in rustc on darwin #352990

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustc: Enable profiler on more platforms #314832

rustc: Enable profiler on more platforms #314832
Artturin wants to merge 1 commit intoNixOS:stagingfrom
Artturin:rustcprofiler

Artturin commented May 26, 2024 •

edited

Loading

Uh oh!

alyssais commented May 26, 2024

Uh oh!

alyssais May 26, 2024

Uh oh!

alyssais left a comment

Uh oh!

Artturin commented May 28, 2024

Uh oh!

Artturin commented May 28, 2024

Uh oh!

Artturin commented Sep 17, 2024

Uh oh!

Artturin commented Sep 19, 2024

Uh oh!

Artturin commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Artturin commented May 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

alyssais commented May 26, 2024

Uh oh!

alyssais May 26, 2024

Choose a reason for hiding this comment

Uh oh!

alyssais left a comment

Choose a reason for hiding this comment

Uh oh!

Artturin commented May 28, 2024

Uh oh!

Artturin commented May 28, 2024

Uh oh!

Artturin commented Sep 17, 2024

Uh oh!

Artturin commented Sep 19, 2024

Uh oh!

Artturin commented Sep 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Artturin commented May 26, 2024 •

edited

Loading