Skip to content

Comments

python312Packages.foolscap: fix build#314721

Merged
risicle merged 1 commit intoNixOS:masterfrom
Moraxyc:fix-foolscap
May 26, 2024
Merged

python312Packages.foolscap: fix build#314721
risicle merged 1 commit intoNixOS:masterfrom
Moraxyc:fix-foolscap

Conversation

@Moraxyc
Copy link
Member

@Moraxyc Moraxyc commented May 26, 2024

Description of changes

fix build (https://hydra.nixos.org/build/260887995)

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 26, 2024
@Moraxyc Moraxyc added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.05 labels May 26, 2024
@Moraxyc Moraxyc requested a review from fabaff May 26, 2024 01:01
@Moraxyc
Copy link
Member Author

Moraxyc commented May 26, 2024

Result of nixpkgs-review pr 314721 run on x86_64-linux 1

8 packages built:
  • python311Packages.foolscap
  • python311Packages.foolscap.dist
  • python312Packages.foolscap
  • python312Packages.foolscap.dist
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 26, 2024
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nixpkgs-review happy, nixos x86_64 & macos 12 x86_64

@risicle risicle merged commit 4615c9d into NixOS:master May 26, 2024
@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants