Skip to content

nixos/etc: support direct symlinks with etc overlay#314579

Merged
nikstur merged 1 commit intoNixOS:masterfrom
ivan770:etc-direct-symlinks
Jun 13, 2024
Merged

nixos/etc: support direct symlinks with etc overlay#314579
nikstur merged 1 commit intoNixOS:masterfrom
ivan770:etc-direct-symlinks

Conversation

@ivan770
Copy link
Member

@ivan770 ivan770 commented May 25, 2024 •
edited
Loading

Description of changes

Closes #311125.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ivan770 ivan770 requested a review from dasJ as a code owner May 25, 2024 12:43
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 25, 2024
@NickCao NickCao mentioned this pull request May 26, 2024
Closed
13 tasks
@arianvp arianvp requested a review from nikstur June 13, 2024 08:57
arianvp
arianvp approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@arianvp arianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but want @nikstur to take a final look as code owner

@nikstur
Copy link
Contributor

nikstur commented Jun 13, 2024

@ofborg test activation-etc-overlay-immutable activation-etc-overlay-mutable

@nikstur nikstur merged commit 2d15501 into NixOS:master Jun 13, 2024
@ivan770 ivan770 deleted the etc-direct-symlinks branch June 13, 2024 15:03
@eclairevoyant eclairevoyant mentioned this pull request Jun 20, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arianvp arianvp arianvp approved these changes

@nikstur nikstur nikstur approved these changes

@dasJ dasJ Awaiting requested review from dasJ

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overlay-based /etc build is failing when the system timezone is set

3 participants

@ivan770 @nikstur @arianvp