Skip to content

glib: Apply fix for memory issues#314043

Merged
jtojnar merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/glib-segfaults
May 28, 2024
Merged

glib: Apply fix for memory issues#314043
jtojnar merged 1 commit intoNixOS:stagingfrom
OPNA2608:fix/glib-segfaults

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented May 23, 2024

Description of changes

See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/4073 and related upstream issues for details.

Fixes:

  • lomiri.lomiri-indicator-network tests
  • lomiri.telephony-service tests
  • lomiri.telephony-service segfault in nixosTests.ayatana-indicators

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was referenced May 23, 2024
Merged
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 23, 2024
jtojnar
jtojnar reviewed May 23, 2024
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Should this perhaps be a release blocker?

@OPNA2608 OPNA2608 mentioned this pull request May 24, 2024
Merged
1 task
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 24, 2024

Should this perhaps be a release blocker?

Maybe? Without at least this, the Lomiri DE's shell & system settings are unbuildable: https://hydra.nixos.org/eval/1806508?filter=lomiri&compare=1806495

Next glib release that would ship this is planned after 24.05 release AFAICT, ~ 06.06.: https://gitlab.gnome.org/GNOME/glib/-/milestones/140

Don't know if anything else is affected by this. Linked issues indicate maybe mousepad, handbrake, libreoffice-qt. Haven't checked any of them yet though.

This was referenced May 24, 2024
Merged
Merged
@jtojnar jtojnar merged commit 79d4b41 into NixOS:staging May 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

Successfully created backport PR for staging-24.05:

@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@lovek323 lovek323 Awaiting requested review from lovek323

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OPNA2608 @jtojnar