Skip to content

mdadm: fix build with musl 1.2.5#313936

Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom
yu-re-ka:musl-mddam
May 29, 2024
Merged

mdadm: fix build with musl 1.2.5#313936
yu-re-ka merged 1 commit intoNixOS:masterfrom
yu-re-ka:musl-mddam

Conversation

@yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented May 23, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais mentioned this pull request May 23, 2024
Merged
47 tasks
@ofborg ofborg bot requested a review from Ekleog May 23, 2024 10:08
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 23, 2024
@yu-re-ka yu-re-ka requested a review from alyssais May 24, 2024 08:10
@alyssais
Copy link
Member

alyssais commented May 24, 2024

I think we'll need md-raid-utilities/mdadm#14 or we'll get segfaults at runtime:

Monitor.c: In function ‘Monitor’:
Monitor.c:257:34: warning: implicit declaration of function ‘basename’ [-Wimplicit-function-declaration]
  257 |                                  basename(mdlist->devname));
      |                                  ^~~~~~~~

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented May 29, 2024

I think we'll need md-raid-utilities/mdadm#14 or we'll get segfaults at runtime:

Applied

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 29, 2024
@yu-re-ka yu-re-ka merged commit b860928 into NixOS:master May 29, 2024
@yu-re-ka yu-re-ka deleted the musl-mddam branch May 29, 2024 14:52
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 29, 2024
Closed
1 task
florian-sanders-cc pushed a commit to florian-sanders-cc/nixpkgs that referenced this pull request Jun 6, 2024
@yuyuyureka @florian-sanders-cc
mdadm: fix build with musl 1.2.5 (NixOS#313936)
7103ed7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yu-re-ka @alyssais @SuperSandro2000 @wegank @yuyuyureka