openjdk17, openjfx17, corretto17: update#313927
Merged
thiagokokada merged 3 commits intoNixOS:masterfrom May 26, 2024
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
16 tasks
Contributor
|
Needs rebase. |
wegank
force-pushed
the
openjdk-bump-split-4
branch
from
54190e8 to
1ea5928
Compare
Member
Author
|
Another hash mismatch for |
Removes the FixNullPtrCast patch, as it failed to apply. Need to investigate whether the patch needs to be updated for this version, or if the patch was backported into corretto's JDK source.
wegank
force-pushed
the
openjdk-bump-split-4
branch
from
1ea5928 to
09b0b53
Compare
Member
Author
|
@ofborg build electron electron.passthru.tests |
thiagokokada
approved these changes
May 26, 2024
Member
|
This broke evaluation. Test case e.g.: nix eval -f. corretto17.outPath --argstr system x86_64-darwinBlocking the |
13 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Split from #286267.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.