Skip to content

letterpress: init at 2.1#313689

Merged
marcusramberg merged 1 commit intoNixOS:masterfrom
dawidd6:letterpress
May 28, 2024
Merged

letterpress: init at 2.1#313689
marcusramberg merged 1 commit intoNixOS:masterfrom
dawidd6:letterpress

Conversation

@dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented May 22, 2024 •
edited
Loading

Description of changes

As part of: #195280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dawidd6 dawidd6 marked this pull request as ready for review May 22, 2024 17:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 22, 2024
Aleksanaa
Aleksanaa reviewed May 25, 2024
View reviewed changes
@Aleksanaa
Copy link
Member

Aleksanaa commented May 27, 2024

My preview isn't shown in monospace font, but I'm not sure if it's a font configuration problem. Are you the same?

image

@Aleksanaa Aleksanaa mentioned this pull request May 27, 2024
Closed
31 tasks
@dawidd6
Copy link
Contributor Author

dawidd6 commented May 27, 2024 •
edited
Loading

I'm not sure if we should include this project in nixpkgs.

Project's author is reluctant on supporting other packaging formats (other than flatpak):
https://gitlab.gnome.org/World/Letterpress/-/merge_requests/16#note_2120586

Also the thumb down on this PR from them is telling.

@Aleksanaa
Copy link
Member

Aleksanaa commented May 27, 2024

It's up to you. I don't consider that as a problem as long as you can make it work.

@dawidd6
Copy link
Contributor Author

dawidd6 commented May 27, 2024

My preview isn't shown in monospace font, but I'm not sure if it's a font configuration problem. Are you the same?

image

Looks fine in a fresh VM:

image

Aleksanaa
Aleksanaa reviewed May 27, 2024
View reviewed changes
marcusramberg
marcusramberg approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I get monospaced output in i3.

@marcusramberg marcusramberg merged commit f807ccb into NixOS:master May 28, 2024
@dawidd6 dawidd6 deleted the letterpress branch May 28, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@marcusramberg marcusramberg marcusramberg approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dawidd6 @Aleksanaa @marcusramberg