Skip to content

share-preview: init at 0.5.0#313676

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
Aleksanaa:share-preview
May 24, 2024
Merged

share-preview: init at 0.5.0#313676
Aleksanaa merged 2 commits intoNixOS:masterfrom
Aleksanaa:share-preview

Conversation

@Aleksanaa
Copy link
Member

@Aleksanaa Aleksanaa commented May 22, 2024

Description of changes

Tested

image

Closes #256453
Closes #208917
part of #195280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 22, 2024
@Aleksanaa Aleksanaa requested a review from wegank May 23, 2024 04:22
@Aleksanaa
Copy link
Member Author

Aleksanaa commented May 23, 2024

x86_64-linux and aarch64-linux succeeded.

x86_64-darwin and aarch64-darwin failed:

  running: env -u IPHONEOS_DEPLOYMENT_TARGET "clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=x86_64-apple-darwin" "-I" "curl/lib" "-I" "curl/include" "-I" "/private/tmp/nix-build-share-preview-0.5.0.drv-0/source/build/target/release/build/libnghttp2-sys-bd624ca8dc17e98e/out/i/include" "-fvisibility=hidden" "-DBUILDING_LIBCURL" "-DCURL_DISABLE_DICT" "-DCURL_DISABLE_GOPHER" "-DCURL_DISABLE_IMAP" "-DCURL_DISABLE_LDAP" "-DCURL_DISABLE_LDAPS" "-DCURL_DISABLE_POP3" "-DCURL_DISABLE_RTSP" "-DCURL_DISABLE_SMB" "-DCURL_DISABLE_SMTP" "-DCURL_DISABLE_TELNET" "-DCURL_DISABLE_TFTP" "-DCURL_STATICLIB" "-DENABLE_IPV6" "-DHAVE_ASSERT_H" "-DOS=\"unknown\"" "-DHAVE_ZLIB_H" "-DHAVE_LONGLONG" "-DHAVE_LIBZ" "-DHAVE_BOOL_T" "-DHAVE_STDBOOL_H" "-DHAVE_GETADDRINFO" "-DHAVE_GETPEERNAME" "-DHAVE_GETSOCKNAME" "-DCURL_DISABLE_NTLM" "-DCURL_DISABLE_FTP" "-DUSE_NGHTTP2" "-DNGHTTP2_STATICLIB" "-DUSE_SECTRANSP" "-DHAVE_BUILTIN_AVAILABLE=1" "-DRECV_TYPE_ARG1=int" "-DHAVE_PTHREAD_H" "-DHAVE_ARPA_INET_H" "-DHAVE_ERRNO_H" "-DHAVE_FCNTL_H" "-DHAVE_NETDB_H" "-DHAVE_NETINET_IN_H" "-DHAVE_NETINET_TCP_H" "-DHAVE_POLL_H" "-DHAVE_FCNTL_O_NONBLOCK" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_STAT_H" "-DHAVE_UNISTD_H" "-DHAVE_RECV" "-DHAVE_SELECT" "-DHAVE_SEND" "-DHAVE_SOCKET" "-DHAVE_STERRROR_R" "-DHAVE_SOCKETPAIR" "-DHAVE_STRUCT_TIMEVAL" "-DHAVE_SYS_UN_H" "-DUSE_THREADS_POSIX" "-DUSE_UNIX_SOCKETS" "-DRECV_TYPE_ARG2=void*" "-DRECV_TYPE_ARG3=size_t" "-DRECV_TYPE_ARG4=int" "-DRECV_TYPE_RETV=ssize_t" "-DSEND_QUAL_ARG2=const" "-DSEND_TYPE_ARG1=int" "-DSEND_TYPE_ARG2=void*" "-DSEND_TYPE_ARG3=size_t" "-DSEND_TYPE_ARG4=int" "-DSEND_TYPE_RETV=ssize_t" "-DSIZEOF_CURL_OFF_T=8" "-DSIZEOF_INT=4" "-DSIZEOF_SHORT=2" "-D__APPLE__" "-Dmacintosh" "-DHAVE_MACH_ABSOLUTE_TIME" "-DSIZEOF_SSIZE_T=8" "-DSIZEOF_SIZE_T=8" "-DSIZEOF_LONG=8" "-o" "/private/tmp/nix-build-share-preview-0.5.0.drv-0/source/build/target/release/build/curl-sys-9504a8a2c416c705/out/build/curl/lib/hostip.o" "-c" "curl/lib/hostip.c"
  cargo:warning=curl/lib/hostip.c:72:10: fatal error: 'SystemConfiguration/SCDynamicStoreCopySpecific.h' file not found
  cargo:warning=#include <SystemConfiguration/SCDynamicStoreCopySpecific.h>
  cargo:warning=         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=1 error generated.
  exit status: 1
  --- stderr

Added darwin.apple_sdk.frameworks.SystemConfiguration, trying again

@wegank
Copy link
Member

wegank commented May 23, 2024

I think you also need at least -Wno-error=incompatible-function-pointer-types in env.NIX_CFLAGS_COMPILE. But I'm not sure if I'll be able to fix the package in the next few hours, before I lose connections on a long-distance train.

@Aleksanaa Aleksanaa merged commit 42b94fa into NixOS:master May 24, 2024
@Aleksanaa Aleksanaa deleted the share-preview branch May 24, 2024 06:49
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 24, 2024
Merged
1 task
@Aleksanaa Aleksanaa mentioned this pull request May 27, 2024
Closed
31 tasks
Sobte pushed a commit to Sobte/nixpkgs that referenced this pull request May 28, 2024
@Aleksanaa @wegank @Sobte
share-preview: init at 0.5.0 (NixOS#313676)
7c95da2 
* share-preview: init at 0.5.0

* share-preview: fix build on darwin

---------

Co-authored-by: Weijia Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank Awaiting requested review from wegank

1 more reviewer

@dawidd6 dawidd6 dawidd6 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Share Preview - Test social media cards locally

3 participants

@Aleksanaa @wegank @dawidd6