Skip to content

e2fsprogs: 1.47.0 -> 1.47.1#313657

Merged
7c6f434c merged 3 commits intoNixOS:stagingfrom
yu-re-ka:e2fsprogs
May 24, 2024
Merged

e2fsprogs: 1.47.0 -> 1.47.1#313657
7c6f434c merged 3 commits intoNixOS:stagingfrom
yu-re-ka:e2fsprogs

Conversation

@yu-re-ka
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yu-re-ka yu-re-ka mentioned this pull request May 22, 2024
47 tasks
@ofborg ofborg bot requested a review from edolstra May 22, 2024 13:20
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 22, 2024
@ofborg ofborg bot requested a review from 7c6f434c May 22, 2024 14:08
@7c6f434c
Copy link
Member

Sounds like e2fsprogs are deps of a few core things, thus this has to target staging.

@yu-re-ka yu-re-ka marked this pull request as draft May 22, 2024 15:18
@yu-re-ka yu-re-ka changed the base branch from master to staging May 22, 2024 19:59
@yu-re-ka yu-re-ka marked this pull request as ready for review May 23, 2024 06:47
@yu-re-ka yu-re-ka requested a review from alyssais May 24, 2024 08:10
@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 24, 2024
@7c6f434c 7c6f434c merged commit b49ae4c into NixOS:staging May 24, 2024
@alyssais
Copy link
Member

Broke libblockdev: #315051

@yu-re-ka yu-re-ka deleted the e2fsprogs branch May 29, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants