buildMavenPackage: Add overrideMavenAttrs function and buildOffline documentation#313152
buildMavenPackage: Add overrideMavenAttrs function and buildOffline documentation#313152tomodachi94 merged 3 commits intoNixOS:masterfrom
overrideMavenAttrs function and buildOffline documentation#313152Conversation
github-actions
bot
added
the
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build lemminx dbeaver java-language-server h2 scenebuilder schemaspy |
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Discussed at #ZurichZHF
|
@roberth Any idea on how to make this work with finalAttrs? jd-cli.overrideMavenAttrs (finalAttrs: old: rec {
... |
I'm not 100% sure what it should mean, and while it could be done, the "architecture" - functions composed in sequence, but made overridable - does not make this easy, and requires that the logic to make that work have knowledge about all other relevant overriding functions, such as I'm sure you could make it work for limited use cases, e.g. initially not supporting |
wegank
added
the
2.status: merge conflict
tricktron
force-pushed
the
override-maven-attrs
branch
from
4e613d3 to
e2d1c01
Compare
github-actions
bot
added
6.topic: nixos
tricktron
force-pushed
the
override-maven-attrs
branch
from
e2d1c01 to
a91a5b5
Compare
github-actions
bot
removed
6.topic: nixos
nix-owners
bot
requested review from
FliegendeWurst,
Infinidoge,
chayleaf and
tomodachi94
tricktron
force-pushed
the
override-maven-attrs
branch
6 times, most recently
from
9eddd45 to
b6b7208
Compare
and offline build usage.
tricktron
force-pushed
the
override-maven-attrs
branch
from
b6b7208 to
cbb3cec
Compare
|
@roberth @fricklerhandwerk I cleaned up the pr for you guys. Unfortunately, I cannot attend the second ZHF day, so I won't be onsite for more interesting discussions. |
|
This is interesting. I'm generally not opposed to this, but I think the plan should be to eventually remove |
|
Also, @tricktron and company: It would be awesome to see you in #jvm:nixos.org if you're interested in helping maintain the Nixpkgs Java ecosystem at all 🙂 |
I have discussed the same thing with @wegank today and I agree that setup hooks might be an even better improvement. So we could first merge that in and setup the switch to setup hooks in a future pr. I am fine with contributing to that too. What do you think? |
I think that would be ideal in this situation. I'll take a look at this in a moment (if I can wrap my head around how overrides work behind the scenes 😉). |
ofborg
bot
added
10.rebuild-darwin: 1-10
|
@fricklerhandwerk Could you unblock merging this and/or update your needed points? |
tomodachi94
left a comment
tomodachi94
left a comment
There was a problem hiding this comment.
Lgtm, thank you 💖 If you're interested in maintaining this package, I encourage you to add yourself to meta.maintainers.
tomodachi94
added
12.approvals: 2
wegank
removed
the
12.approved-by: package-maintainer
github-actions
bot
added
the
6.topic: java
Sure, I added myself to the maintainer list. I may also be interested to join the Nixos Java team in the future. For now, I'll try to check in from time to time to https://matrix.to/#/#jvm:nixos.org but probably more as a silent reader if that is ok:smiley:. |
tomodachi94
left a comment
tomodachi94
left a comment
There was a problem hiding this comment.
Sounds good, thank you ❤️ If you have something to say, feel free to provide input when there's discussion in the channel.
|
Just saw that this happened, so I quickly threw together an alternative: #359573 |
6 participants
Description of changes
This pr does the following:
overrideMavenAttrsfunction to make it possible to override attributes of thebuildMavenPackagefunction.overrideMavenAttrsfunction.buildOffline = trueargument for thebuildMavenPackagefunction.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.