Skip to content

python311Packages.freud: init at 3.0.0#313079

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
doronbehar:pkg/py-freud
Jun 2, 2024
Merged

python311Packages.freud: init at 3.0.0#313079
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
doronbehar:pkg/py-freud

Conversation

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 20, 2024

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 20, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2024
@doronbehar
Copy link
Contributor Author

doronbehar commented May 26, 2024

@ofborg build python312Packages.freud

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label May 26, 2024
@nixos-discourse
Copy link

nixos-discourse commented May 26, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3990

SuperSandro2000
SuperSandro2000 reviewed May 26, 2024
View reviewed changes
pkgs/development/python-modules/freud/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 May 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably patch that tp just numpy

Copy link
Contributor Author

@doronbehar doronbehar May 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably patch that tp just numpy

There is a difference between the two, and many packages require oldest-supported-numpy. TBH I don't understand the idea behind this meta package. Note that even in Nixpkgs it is defined to simply propagate numpy so I think it's OK.

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a meta package which requires the last numpy upstream support IIRC

pkgs/development/python-modules/freud/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 May 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use our Eigen?

Copy link
Contributor Author

@doronbehar doronbehar May 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use our Eigen?

Indeed it would have been nice, I haven't thought about it. However, upstream doesn't seem to support that out of the box via a cmake option or a like. Also I'm not sure it will save us space, because upstream doesn't distribute eventually all of eigen's libraries. I added a sentence to the comment explaining the reasoning.

@doronbehar doronbehar mentioned this pull request May 29, 2024
Open
13 tasks
@doronbehar
Copy link
Contributor Author

doronbehar commented May 29, 2024

I now noticed I didn't enable the tests, so here are them now.

@doronbehar
Copy link
Contributor Author

doronbehar commented May 29, 2024

I will wait for CI on all platforms.

@SuperSandro2000 SuperSandro2000 merged commit 97ac5d9 into NixOS:master Jun 2, 2024
@doronbehar doronbehar deleted the pkg/py-freud branch June 8, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doronbehar @nixos-discourse @SuperSandro2000