haskellPackages.ghc-lib: fix eval#312493
Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom May 17, 2024
Merged
Conversation
alexfmpe
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Something of a follow-up to #306098
A previous run of
regenerate-hackage-packages.shgot a more recent 'latest' version from hackage thus breaking eval. Curiously, the regenerate script seems to depend onghc-syntax-highlighter_0_0_11_0meaning it can break itself (which is why I ran into this in the first place). Should the script do an eval check at the end to warn about this?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.