Skip to content

python312Packages.flaky: refactor#312260

Closed
fabaff wants to merge 2 commits intoNixOS:masterfrom
fabaff:flaky-refactor
Closed

python312Packages.flaky: refactor#312260
fabaff wants to merge 2 commits intoNixOS:masterfrom
fabaff:flaky-refactor

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented May 16, 2024

  • migrate to pytestCheckHook
  • add pythonImportsCheck

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fabaff added 2 commits May 16, 2024 18:47
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 16, 2024
@fabaff fabaff mentioned this pull request May 16, 2024
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 16, 2024
Qyriad
Qyriad approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built on aarch64-darwin and x86_64-linux

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels May 17, 2024
@mweinelt mweinelt closed this Aug 3, 2024
@fabaff fabaff deleted the flaky-refactor branch December 18, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Qyriad Qyriad Qyriad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabaff @Qyriad @mweinelt @wegank