Conversation
ofborg
bot
added
10.rebuild-darwin: 101-500
Ericson2314
force-pushed
the
aa-openbsd-1
branch
2 times, most recently
from
03fdb46 to
7a7a107
Compare
rhelmot
left a comment
rhelmot
left a comment
There was a problem hiding this comment.
no showstoppers, just some questions and advice from the freebsd mines
There was a problem hiding this comment.
What packages have you tried compiling with this libc? I found that there were actually a bunch more libraries on freebsd which were required pretty much constantly, once you got into more interesting applications, like rust packages and stuff built with meson.
There was a problem hiding this comment.
Just the basics, we will also need to add more stuff
Ericson2314
force-pushed
the
aa-openbsd-1
branch
2 times, most recently
from
9315838 to
eda41d7
Compare
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
First, thank you so much for splitting this into small, easily reviewable commits.
How come we're using NetBSD make and working around its differences instead of just building OpenBSD make?
pkgs/os-specific/bsd/openbsd/pkgs/libc/libpthread-no-werror.patch
Outdated
Show resolved
Hide resolved
OpenBSD doesn't have any I am still chuckling about this :) |
ali-abrar
force-pushed
the
aa-openbsd-1
branch
9 times, most recently
from
774a4b3 to
8fce018
Compare
wegank
added
the
12.approvals: 1
Co-authored-by: Rahul Butani <[email protected]>
See: https://github.com/NixOS/nixpkgs/pull/246577/files#r1600650238 This code was breaking some thing for me, and I believe it was a mistake. I hink we *do* wanna link libc, since libc++ depends on it, but *don't* want to link an already-existing C++ standard library implementation. `-nostdlib++` without `-nostdlib` therefore seems correct to me. Without this change, we do indeed fail to link OpenBSD.
See the code comments for details Also replace a bad hard-coded `freebsd` with a flexible `*` wildcard in the `doFakeLibgcc` implementation.
rrbutani
added
the
6.topic: llvm/clang
wegank
removed
the
12.approvals: 1
wegank
added
12.approvals: 1
|
Successfully created backport PR for |
|
Glad to see this PR has been merged, thank you for your work, @ali-abrar, can't wait to try it out! 💯 |
|
Sorry but this seems to break |
|
Ah I wonder if that's because we updated LLVM and now the patch is already there and doesn't need backporting any more. |
|
patches reverted in: #315790 |
|
Sorry about that! Though it is nice LLVM 18 is already upgraded :) |
10 participants
Description of changes
Add OpenBSD support similar to FreeBSD/NetBSD. We use some NetBSD tools to help bootstrap. Currently these are known o build:
Actually running these OpenBSD executables on OpenBSD will take more work, but @Ericson2314 thinks that is fine for now, because it is easier to fix that after there is a building foundation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.