python312Packages.bayespy: add missing dependency, clean up; python312Packages.truncnorm: init at 0.0.2#311489
Merged
wegank merged 2 commits intoNixOS:masterfrom May 14, 2024
Merged
Conversation
177464b to
ec53d50
Compare
Member
|
Result of 8 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
ZHF: #309482
This package fixes the build of the
bayespypackage by adding the missingtruncnormdependency, which hasn't been packaged yet.I used
pyproject = truefor both packages.I also opted to use the GitHub sources instead of the PyPi sources.
@jluttine, I added you as a maintainer for
truncnorm, because you maintain thebayespypackage both upstream and in nixpkgs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.