Skip to content

python3Packages.{pxml,cadquery,globre,cryptacular,pathlib}, cq-editor: remove#311201

Merged
mweinelt merged 10 commits intoNixOS:masterfrom
Sigmanificient:python-revemove-38
May 13, 2024
Merged

python3Packages.{pxml,cadquery,globre,cryptacular,pathlib}, cq-editor: remove#311201
mweinelt merged 10 commits intoNixOS:masterfrom
Sigmanificient:python-revemove-38

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented May 12, 2024

Description of changes

Removed the python packages pxml, cadquery, globre, cryptacular, pathlib as they require a python version that has reached end of life and had not sign of being maintained (last updated in 2019, 2020 and 2021) (see end of life chart below).

Removed cq-editor has is depend on cadquery.
Updated the python packages slicedimage, pyscss, sqlbag to require 3.4+.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 12, 2024
@Sigmanificient Sigmanificient added the 8.has: clean-up This PR removes packages or removes other cruft label May 12, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 13, 2024
@Sigmanificient Sigmanificient requested a review from mweinelt May 13, 2024 15:03
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good cleanup

@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 13, 2024
@mweinelt mweinelt merged commit 0cb7877 into NixOS:master May 13, 2024
@Sigmanificient Sigmanificient deleted the python-revemove-38 branch May 13, 2024 22:26
mjoerg added a commit to mjoerg/nixpkgs that referenced this pull request Jul 17, 2024
@mjoerg mjoerg mentioned this pull request Jul 17, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants