haskellPackages.ghcjs-dom: build on js backend of ghc 9.8 by alexfmpe · Pull Request #309650 · NixOS/nixpkgs

alexfmpe · 2024-05-06T20:52:44Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

alexfmpe · 2024-05-06T20:53:50Z

I assume on 9.6 the FFI support wasn't there yet as the build fails with

Preprocessing library for ghcjs-base-0.8.0.0..
Building library for ghcjs-base-0.8.0.0..
[ 1 of 73] Compiling Data.JSString.Internal ( Data/JSString/Internal.hs, dist/build/Data/JSString/Internal.o )
[ 2 of 73] Compiling Data.JSString.Internal.Fusion.Types ( Data/JSString/Internal/Fusion/Types.hs, dist/build/Data/JSString/Internal/Fusion/Types.o )
[ 3 of 73] Compiling Data.JSString.Internal.Fusion.CaseMapping ( Data/JSString/Internal/Fusion/CaseMapping.hs, dist/build/Data/JSString/Internal/Fusion/CaseMapping.o )
[ 4 of 73] Compiling Data.JSString.Internal.Fusion.Common ( Data/JSString/Internal/Fusion/Common.hs, dist/build/Data/JSString/Internal/Fusion/Common.o )
[ 5 of 73] Compiling GHCJS.Concurrent ( GHCJS/Concurrent.hs, dist/build/GHCJS/Concurrent.o )

GHCJS/Concurrent.hs:37:1: error:
    Could not find module ‘GHC.JS.Foreign.Callback’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
37 | import           GHC.JS.Foreign.Callback (OnBlocked(..))
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ 6 of 73] Compiling GHCJS.Internal.Types ( GHCJS/Internal/Types.hs, dist/build/GHCJS/Internal/Types.o )

GHCJS/Internal/Types.hs:17:1: error:
    Could not find module ‘GHC.JS.Foreign.Callback’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
17 | import GHC.JS.Foreign.Callback (Callback)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[25 of 73] Compiling JavaScript.Cast  ( JavaScript/Cast.hs, dist/build/JavaScript/Cast.o )
[32 of 73] Compiling JavaScript.Number ( JavaScript/Number.hs, dist/build/JavaScript/Number.o )

pkgs/development/haskell-modules/configuration-ghcjs-9.x.nix

alexfmpe · 2024-05-06T21:02:44Z

pkgs/development/haskell-modules/default.nix

I tried to add this before, alongside the other platformConfigurations, but the overrides would get lost as configuration-ghc-9.8.nix (passed in compilerConfig) would then reset to null or overwrite due to picking the most-recent hackage version.

That’s unfortunate.

I don’t get it. there do not seem to be conflicting overrides for the packages in ghcjs-9.x.nix after the changes you are making. Are you sure this doesn’t work?

Are you sure this doesn’t work?

Confirmed to be working now. I think the problem is that I originally had

aeson = disableLibraryProfiling super.aeson;

which was being replaced by the flat aeson override in the 9.8 bit but now we disable profiling globally for JS flavors so this is no longer a problem.

sternenseemann · 2024-05-07T10:30:47Z

8c61a34 should simplify this PR a lot! I'm wondering if we even need a special file for the js backend at all. Most of these packages wouldn't build with normal GHCs anyways, so we can apply the overrides in the normal configuration-nix.nix? Or do you think there's an advantage in having them conditional? The disadvantage of this is that eval regressions won't be caught since we can't test the entire set on Hydra…

alexfmpe · 2024-05-07T15:52:24Z

8c61a34 should simplify this PR a lot!

Huh, how? DId you mean the addBuildDepends self.ghcjs-base shouldn't be needed anymore?
Looking at that diff it doesn't seem hackage-packages.nix changed anything in the dependent packages generation.

With this change, the ghcjs-base = super.ghcjs-base_0_8_0_0; override fails but if I remove it I get

$ nix-build -A pkgsCross.ghcjs.haskell.packages.ghc98.ghcjs-base                                                                                                                        
error:
(...)
           12|   (self: super: {
           13|     ghcjs-base = addBuildDepends (with self; [
             |     ^
           14|       aeson

       (stack trace truncated; use '--show-trace' to show the full trace)
       error: value is null while a set was expected

I think the change also requires removing

nixpkgs/pkgs/development/haskell-modules/configuration-common.nix

Line 270 in 8c61a34

ghcjs-base = null;

so that it builds on pkgsCross.ghcjs.

That in turn makes nix-build -A haskell.packages.ghc98.ghcjs-base switch from

error: expression does not evaluate to a derivation (or a set or list of those)

to

(...)
Running phase: buildPhase
Building ghcjs-base-0.8.0.0...
Running phase: checkPhase
Package has no test suites.
Running phase: haddockPhase
Warning: No documentation was generated as this package does not contain a
library. Perhaps you want to use the --executables, --tests, --benchmarks or
--foreign-libraries flags.
Running phase: installPhase
Error: Setup: No executables and no library found. Nothing to do.

error: builder for '/nix/store/nw2fyq4r6vv34nv8jlf9g3dvrkh5i0yv-ghcjs-base-0.8.0.0.drv' failed with exit code 1;
       last 10 log lines:

so we probably should set its supported platforms, but that needs the call2nix release.

Edit: Done

alexfmpe · 2024-06-09T00:18:27Z

Anything left to do here?

maralorn · 2024-06-12T17:19:29Z

Thank you very much!

Any explanation regarding the white space changes in hackage-packages.nix?

I left one other comment. Apart from that this looks good to me.

Ah, do we already have enough hydra jobs for this?

sternenseemann · 2024-06-12T22:28:23Z

pkgs/development/haskell-modules/default.nix

I'd prefer if we could just use platformConfigurations for this instead.

Agreed. This now works, as per: #309650 (comment)

alexfmpe · 2024-06-14T19:28:53Z

Any explanation regarding the white space changes in hackage-packages.nix?

Oops, fixed.
My editor automatically trimmed the trailing whitespace after I manually edited the file to handle a conflict with #316272

sternenseemann · 2024-06-14T21:02:03Z

Ah, do we already have enough hydra jobs for this?

Probably not, we should expand that, but that can probably be done in a follow up change.

alexfmpe requested review from maralorn, ncfavier and sternenseemann as code owners May 6, 2024 20:52

github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 6, 2024

alexfmpe commented May 6, 2024

View reviewed changes

pkgs/development/haskell-modules/configuration-ghcjs-9.x.nix Outdated Show resolved Hide resolved

alexfmpe commented May 6, 2024

View reviewed changes

pkgs/development/haskell-modules/configuration-ghcjs-9.x.nix Outdated Show resolved Hide resolved

alexfmpe commented May 6, 2024

View reviewed changes

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 6, 2024

alexfmpe marked this pull request as draft May 6, 2024 21:42

alexfmpe force-pushed the ghcjs-dom branch from 002cdc9 to 03ba2a6 Compare May 6, 2024 21:54

alexfmpe marked this pull request as ready for review May 6, 2024 21:55

alexfmpe mentioned this pull request May 6, 2024

Support GHC JavaScript backend dmjio/miso#738

Merged

alexfmpe force-pushed the ghcjs-dom branch from 03ba2a6 to 1c34095 Compare May 13, 2024 19:35

alexfmpe mentioned this pull request May 14, 2024

Support building with ghc-9.8 js backend reflex-frp/reflex-dom#471

Merged

alexfmpe force-pushed the ghcjs-dom branch 2 times, most recently from 564ef5d to 50cc576 Compare May 20, 2024 14:39

alexfmpe marked this pull request as draft May 20, 2024 14:40

alexfmpe force-pushed the ghcjs-dom branch from 50cc576 to 9a2857d Compare May 20, 2024 17:08

alexfmpe marked this pull request as ready for review May 20, 2024 17:08

alexfmpe force-pushed the ghcjs-dom branch from 9a2857d to a7d95e2 Compare May 25, 2024 15:20

alexfmpe force-pushed the ghcjs-dom branch from a7d95e2 to e6635f2 Compare June 9, 2024 00:10

ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 9, 2024

sternenseemann self-assigned this Jun 12, 2024

sternenseemann reviewed Jun 12, 2024

View reviewed changes

sternenseemann mentioned this pull request Jun 12, 2024

haskellPackages: another round of mass-rebuilds #318363

Merged

haskellPackages.ghcjs-dom: build on js backend of ghc 9.8

b18a187

alexfmpe force-pushed the ghcjs-dom branch from e6635f2 to b18a187 Compare June 14, 2024 19:26

alexfmpe changed the title ~~ghcjs-dom: build on js backend of ghc 9.8~~ haskellPackages.ghcjs-dom: build on js backend of ghc 9.8 Jun 14, 2024

sternenseemann approved these changes Jun 14, 2024

View reviewed changes

sternenseemann merged commit cadb3d1 into NixOS:haskell-updates Jun 14, 2024

alexfmpe deleted the ghcjs-dom branch June 28, 2024 18:06

Uh oh!

Conversation

alexfmpe commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

alexfmpe commented May 6, 2024

Uh oh!

Uh oh!

Uh oh!

alexfmpe May 6, 2024

Choose a reason for hiding this comment

Uh oh!

maralorn Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

maralorn Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

alexfmpe Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

sternenseemann commented May 7, 2024

Uh oh!

alexfmpe commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexfmpe commented Jun 9, 2024

Uh oh!

maralorn commented Jun 12, 2024

Uh oh!

sternenseemann Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

alexfmpe Jun 14, 2024

Choose a reason for hiding this comment

Uh oh!

alexfmpe commented Jun 14, 2024

Uh oh!

sternenseemann commented Jun 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexfmpe commented May 6, 2024 •

edited

Loading

alexfmpe commented May 7, 2024 •

edited

Loading