haskellPackages: fix build of SOP libraries#308919
Merged
ncfavier merged 5 commits intoNixOS:haskell-updatesfrom May 13, 2024
Merged
haskellPackages: fix build of SOP libraries#308919ncfavier merged 5 commits intoNixOS:haskell-updatesfrom
ncfavier merged 5 commits intoNixOS:haskell-updatesfrom
Conversation
alexfmpe
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
alexfmpe
changed the title
alexfmpe
commented
May 3, 2024
Comment on lines
-3791
to
-3790
Member
Author
There was a problem hiding this comment.
I don't know what these are but they all build now
alexfmpe
commented
May 3, 2024
Comment on lines
2628
to
2632
Member
Author
There was a problem hiding this comment.
Running phase: patchPhase
applying patch /nix/store/h873fgkxxgxrmdmn4czxh7lzv8l6wxfd-d88831388ab3041190130fec3cdd679a4217b3c7.patch
patching file records-sop.cabal
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file records-sop.cabal.rej
error: builder for '/nix/store/084g16rjasb2ja2rq9yxx2iqpz12ahal-records-sop-0.1.1.1.drv' failed with exit code 1;
ofborg
bot
added
8.has: package (new)
Member
|
Can you add a bit more comment to the overrides? Maybe a version assert, upstream issue or pr? |
alexfmpe
force-pushed
the
haskellPackages-sop
branch
from
16d9d1a to
855988c
Compare
alexfmpe
force-pushed
the
haskellPackages-sop
branch
from
855988c to
67eb894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.