Don't run tests when cross-compiling#30883
Merged
Ericson2314 merged 10 commits intoNixOS:masterfrom Nov 5, 2017
Merged
Conversation
8 tasks
Contributor
|
Are there any packages whose check phase works during cross compilation? |
Contributor
Author
|
Orivej Desh <[email protected]> writes:
Are there any packages whose check phase works during cross compilation?
While I can't say "no" with certainty, I would expect they would be the
exception, not the rule.
Another option here would be to unconditionally disable tests when
cross-compiling. However, this seems unappealingly ad-hoc and one of
those things that you will some day come to regret.
|
Contributor
|
What if the mkDerivation function grew a doCheck parameter which defaulted to true for host builds and false for target builds? It could be overridden per package, but would have correct default value for the common case. I think the problem now is that doCheck is just passed right to the shell. (Or perhaps the same mechanism can be implemented at shell level too.) |
Member
|
@bjornfor the problem is the default is always off. This would be easy to fix if the default was always on, in which we'd make it always on just for cross. |
Ericson2314
approved these changes
Nov 5, 2017
Ericson2314
added
the
6.topic: cross-compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A step towards basic cross compilation (see #30882 for the next step).
This only handles a small fraction of cases which will ultimately need to be handled. That being said, it's a large enough fraction to compile everything up to
systemd.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)