Merged
Conversation
Member
Author
|
Friendly ping to @Aleksanaa, @JohnRTitor, and @NovaViper for reviewing and testing 🙂 |
Member
|
@ofborg build blanket |
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Hey, could you avoid double wrapping first? Although I've done it in #303848 I guess I won't work on that PR in a week |
Co-authored-by: aleksana <[email protected]>
Member
Author
|
Unfortunately this PR was merged before I got a chance to reply to your comment, @Aleksanaa. I'm uncertain whether I fully understand what you mean by "double wrapping", can you provide additional context, please? |
Member
|
Just see my above PR. The nixpkgs manual also mentioned this. |
Member
Author
|
ℹ️ Double-wrapping was addressed with 63c8837 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR supercedes #308159 and targets
staging-next, because the changes require a newerlibadwaita, which is only available with Gnome 46, which in Nix is currently only available onstaging-next.Update to 0.7.0 and modernize package as proposed by
nix run github:NixOS/nixfmt.Closes #308146
Things done
Moderni
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.