Skip to content

haskellPackages.cbor-tool: Unbroken#307818

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
mrkline:unbreak-cbor-tool
Apr 29, 2024
Merged

haskellPackages.cbor-tool: Unbroken#307818
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
mrkline:unbreak-cbor-tool

Conversation

@mrkline
Copy link
Contributor

@mrkline mrkline commented Apr 29, 2024

Description of changes

cbor-tool builds again - it was fixed against more recent GHCs in November:
well-typed/cborg@f910b12

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 29, 2024
@mrkline
Copy link
Contributor Author

mrkline commented Apr 29, 2024

pkgs/development/haskell-modules/hackage-packages.nix needs to be updated accordingly, but I wasn't sure if that should be part of this PR as well.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 29, 2024
@maralorn
Copy link
Member

maralorn commented Apr 29, 2024

pkgs/development/haskell-modules/hackage-packages.nix needs to be updated accordingly, but I wasn't sure if that should be part of this PR as well.

This is funny, nearly the same PR twice. Yeah, updating that file would be great. Please see #307815 where I just left complete instructions.

@mrkline mrkline force-pushed the unbreak-cbor-tool branch from d358958 to 9644fc5 Compare April 29, 2024 21:13
@mrkline
Copy link
Contributor Author

mrkline commented Apr 29, 2024

Heh, coworkers chatting on Slack but not being clear on who'd send the PR. Sorry for any extra noise there. 😅

hackage-packages.nix updated!

@maralorn
Copy link
Member

maralorn commented Apr 29, 2024

Still the wrong target branch.

@mrkline mrkline changed the base branch from master to haskell-updates April 29, 2024 21:20
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes labels Apr 29, 2024
@github-actions github-actions bot added 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Apr 29, 2024
@mrkline mrkline force-pushed the unbreak-cbor-tool branch from 9644fc5 to 1e687bc Compare April 29, 2024 21:20
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Apr 29, 2024
@maralorn maralorn merged commit ce0b195 into NixOS:haskell-updates Apr 29, 2024
@mrkline mrkline mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

@ncfavier ncfavier Awaiting requested review from ncfavier

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@figsoda figsoda Awaiting requested review from figsoda

@adisbladis adisbladis Awaiting requested review from adisbladis

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@jbedo jbedo Awaiting requested review from jbedo

@JulienMalka JulienMalka Awaiting requested review from JulienMalka

@infinisil infinisil Awaiting requested review from infinisil

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrkline @maralorn