Skip to content

cbor-tool: unbroken#307815

Closed
cmoog wants to merge 1 commit intoNixOS:masterfrom
cmoog:cmoog/cbor-tool-unbroken
Closed

cbor-tool: unbroken#307815
cmoog wants to merge 1 commit intoNixOS:masterfrom
cmoog:cmoog/cbor-tool-unbroken

Conversation

@cmoog
Copy link
Contributor

@cmoog cmoog commented Apr 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 29, 2024
@maralorn
Copy link
Member

Hello @cmog, thank you for your contribution!

Let me quickly bring you up to speed, how we usually fix packages in the Haskell package set:

  1. Please point your PR at the haskell-updates branch.
  2. Use haskellPackages.cbor-tool in your commit message.
  3. Remove cbor-tool from pkgs/development/haskell-modules/hackage2nix/broken.yaml.
  4. Ideally run maintainers/scripts/haskell/regenerate-hackage-packages.sh.

The last two steps are necessary because hackage-packages.nix is autogenerated.

@cmoog cmoog closed this Apr 29, 2024
@cmoog cmoog deleted the cmoog/cbor-tool-unbroken branch April 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants