Skip to content

[staging] libcamera: fix binary reproduciblity#307719

Merged
Mic92 merged 1 commit intoNixOS:stagingfrom
Mic92:libcamera
May 6, 2024
Merged

[staging] libcamera: fix binary reproduciblity#307719
Mic92 merged 1 commit intoNixOS:stagingfrom
Mic92:libcamera

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 29, 2024

Description of changes

libcamera is a quite important package as it's used for pipewire.
Hence if we want a binary reproducible desktop, we need to ensure that
libcamera also is able to build reproducible.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92
Copy link
Member Author

Mic92 commented Apr 29, 2024

Might need to move this staging. Let's see.

@Mic92 Mic92 changed the base branch from master to staging April 29, 2024 10:35
@Mic92 Mic92 changed the title libcamera: fix binary reproduciblity [staging] libcamera: fix binary reproduciblity Apr 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 29, 2024
@brianmcgillion brianmcgillion self-requested a review May 6, 2024 11:53
Copy link
Contributor

@brianmcgillion brianmcgillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested aginst Ghaf unstable.

@Mic92 Mic92 merged commit 99285ba into NixOS:staging May 6, 2024
@Mic92 Mic92 deleted the libcamera branch May 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants