nixos-option: fix self inclusive src#307564
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Apr 28, 2024
Merged
Conversation
SuperSandro2000
approved these changes
Apr 28, 2024
Member
|
@ofborg build nixos-option |
37 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
This broke the installer tests, somehow: https://hydra.nixos.org/build/258074134/nixlog/829 I don't really get why it's failing, but given this is just a cleanup change, I'm going to revert this and we can reland later. |
Member
|
It is probably triggering a rebuild and we need to copy more things? |
Contributor
|
Potentially. I'm not really familiar with how that entire setup works. |
Member
|
It fails to download zlib which is totally unrelated to the package itself and I remember similar issues in the past. |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #301014
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.