Skip to content

Comments

dell-command-configure: fix self inclusive src#307479

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Stunkymonkey:self-inclusive-src-dell-command-configure
Apr 28, 2024
Merged

dell-command-configure: fix self inclusive src#307479
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Stunkymonkey:self-inclusive-src-dell-command-configure

Conversation

@Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Apr 28, 2024

Description of changes

part of #301014

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 307479 run on x86_64-linux 1

1 package built:
  • dell-command-configure

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 28, 2024
@Stunkymonkey Stunkymonkey force-pushed the self-inclusive-src-dell-command-configure branch from 0f8d875 to 52cb4a0 Compare April 28, 2024 15:50
@Stunkymonkey Stunkymonkey force-pushed the self-inclusive-src-dell-command-configure branch from 52cb4a0 to 6f6cfd5 Compare April 28, 2024 15:51
Copy link
Contributor

@RyanGibb RyanGibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@ofborg ofborg bot requested a review from RyanGibb April 28, 2024 16:17
@SuperSandro2000 SuperSandro2000 merged commit 1f149e0 into NixOS:master Apr 28, 2024
@Stunkymonkey Stunkymonkey deleted the self-inclusive-src-dell-command-configure branch June 2, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants