apple-source-releases: always use python3Minimal#306697
Conversation
ofborg
bot
added
the
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
Using python3Minimal avoids infinite recursions in the stdenv bootstrap on x86_64-darwin when building Python with configd support.
reckenrode
force-pushed
the
apple-oss-python
branch
from
5db18a6 to
0293a35
Compare
|
The force push uses |
|
This was previously achieved by passing in python3Minimal from the bootstrap, no? What's the motivation for changing it around? In principle it's nice for the packages in the final package set to all depend on the same Python rather than have some depend on the minimal version. |
Meson needs a fairly functional Python, and it simplifies things not having to do a ton of overrides to do enable that. Otherwise, I’d have to be doing overrides of configd, xnu, etc to use python3Minimal. |
|
I'm actually fine with overriding it for all the source releases rather than the ones that strictly need it but it would be slightly nicer not to end up with pretty much always needing two copies of Python in the store. Would it be hard to switch to non-minimal Python after bootstrapping? |
Wouldn’t it only be pulled into the store as a build-time dependency?
The way the source releases are implemented in |
toonn
left a comment
toonn
left a comment
There was a problem hiding this comment.
LGTM, tested a couple things still build fine on both Darwins.
Not my favorite solution but it shouldn't be blocked on my account if it'll allow further progress.
2 participants
Description of changes
Using python3Minimal avoids infinite recursions in the stdenv bootstrap on x86_64-darwin when building Python with configd support.
Build was tested on my ld64 branch. Primary issue is ensuring evaluation, which can be tested with
nix-instantiate.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.