Are the rebuilds just because of dontDisableStatic now being false instead of missing (by default)?

Are the rebuilds just because of dontDisableStatic now being false instead of missing (by default)?

I guess so, but that surprises me as well.

what is the advantage of this flag in comparison to pkgsStatic.icu ? (which already builds it seems)

I'd like to be able to statically link outside of pkgsStatic and "just" using dontDisableStatic = true doesn't cut it for icu.

What are the steps to get this merged?

If you drop that line, the change becomes useless, but does the output path return to the old one?

@7c6f434c It took me a while to figure out what you meant, but no the path is different:

git checkout HEAD^
nix build .#icu && ls -l result
lrwxrwxrwx 1 syd users 54 Apr 19 00:57 result -> /nix/store/qwnmd1a9zxfjqgkhv3jyyf86r9jm4gsq-icu4c-73.2
git checkout icu-static
nix build .#icu && ls -l result                  131ms
lrwxrwxrwx 1 syd users 54 Apr 19 00:57 result -> /nix/store/c1m796by7343zg40d90qzr30lgc2k60f-icu4c-73.2

I'm guessing this has something to do with newlines in the postInstall hook.

But if it changes anything about postInstall while withStatic is not enabled, that means we don't actually understand what it changes, and given that pkgsStatic.icu works if really needed, I'd want to understand which parts here are actually non-no-op in which case…

@7c6f434c is there a way to say nix whats-different?

@7c6f434c I just confirmed: It's the presence of the dontDisableStatic env var that changes the store hash. That's unavoidable though.

It is avoidable, but in an ugly way. I wanted it checked that this is the only rebuild-triggering change, though.

Backport failed for staging-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.05
git worktree add -d .worktree/backport-304772-to-staging-24.05 origin/staging-24.05
cd .worktree/backport-304772-to-staging-24.05
git switch --create backport-304772-to-staging-24.05
git cherry-pick -x f3dee8a2e201ee0672d4268a062c3ec6f8f855c4

I guess it was in 24.05 already ..

@7c6f434c I just realised that I added the argument to the wrong function. It should be the former, so that it's overridable, not the later.

If you add the argument to the upper function, you need to re-call the resulting function after overriding and pass it the source hash again. don't you?

@7c6f434c Hm didn't think about it enough maybe. In any case I can't override static now so I still can't use this with pkgsMusl yet :P