icu: Make static linking possible#304756
Closed
NorfairKing wants to merge 287 commits intoNixOS:stagingfrom
Closed
icu: Make static linking possible#304756NorfairKing wants to merge 287 commits intoNixOS:stagingfrom
NorfairKing wants to merge 287 commits intoNixOS:stagingfrom
Conversation
Get permission from Tarn to publish a v50 Dwarf Fortress in nixpkgs. The last time we did this was in 2010. (moved to df_permission/2010)
this is needed, so `minimumRequiredVersion` of vendir.yml works as expected.
In addition to the version bump, I did some refactoring because there were a few issues: 1. Downloading NPM dependencies during install phase does not work. Instead, copy them over from the build phase. 2. Native modules in lib/vscode were not being installed/built at all. 3. Kerberos module will not build (a new issue that appeared as a consequence of fixing the previous issue). Remove it for now. 4. Increase max-old-space-size from the default (I was running out of memory). There are still some issues to look over but these changes are at least an improvement over the status quo. Co-authored-by: Pol Dellaiera <[email protected]>
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
|
This should go into |
NorfairKing
requested review from
IvarWithoutBones,
RaitoBezarius,
dasJ,
edwtjo,
figsoda,
jonringer,
maralorn,
mweinelt,
ncfavier,
sternenseemann,
stigtsp and
zakame
as code owners
github-actions
bot
added
6.topic: python
Contributor
Author
|
Closing because I accidentally pinged a bunch of people. |
7 tasks
ofborg
bot
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Make static linking possible for
icu.Things done
Built on platform(s)
Tested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage^ This took ages, and filled my screen, so I didn't complete it.
Add a 👍 reaction to pull requests you find important.