Conversation
the 'http' package is an interesting one to test because all its lua files are in a 'http' subfolder, ie., there is no share/lua/5.1/*.lua, only share/lua/5.1/http/*.lua files unlike most packages. This tests we can match those subfolders.
the setup-hook checks if a derivation contains lua files matching lua_path patterns. We use bash's globstar extension for that but `**.lua` doesn't return files in subfolders, it has to be `**/*.lua`. Adjust the pattern accordingly.
lua.tests.checkSetupHook: test lua setup hook for http package
Conflicts: pkgs/development/python-modules/colorcet/default.nix
Member
Author
|
Contributor
Yes, we are working on the update here: #303043 |
Member
Author
|
Oh, I had searched but skipped this PR based on title. |
Contributor
Yes, updating |
Updating turns out difficult; see WIP in PR #303043
https://hydra.nixos.org/build/256380975/nixlog/1/tail I don't have energy to try discovering why exactly the issue happens, but adding python3 to propagatedBuildInputs or dropping strictDeps worked when I tried on aarch64-darwin. I suspect that cmake upgrade might've been what triggered the change.
...into staging-next
Member
Author
|
Overall it's still not great, but we might be getting close to mergeable state |
13 tasks
Member
Author
|
I think that the remaining regressions can be brought to wider audience. |
13 tasks
apoelstra
added a commit
to apoelstra/local-nix-ci
that referenced
this pull request
Jun 5, 2024
…nixpkgs After upgrading my nixpkgs channel I started getting mysterious breakage where crate2nix would show "Did not find all crates.io hashes in Cargo.lock" and be unable to produce the generated/called nixfiles. It appears the culprit is somewhere in NixOS/nixpkgs#303527 and it was fixed in 640584db14761545480c0d29b80c3ab34a3236bd of crate2nix (part of #341). We previously had been pinned to an old version of crate2nix due to incompatibility with cargo 1.48 but fortunately the rust-bitcoin ecosystem has since moved on to 1.56.1 so we are ok to upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful links
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
Mass breakages
nothing notable so far