tests.importCargoLock: fix self-inclusive src listings in .nix files#303146
Merged
infinisil merged 1 commit intoNixOS:masterfrom Apr 11, 2024
Merged
tests.importCargoLock: fix self-inclusive src listings in .nix files#303146infinisil merged 1 commit intoNixOS:masterfrom
infinisil merged 1 commit intoNixOS:masterfrom
Conversation
Replace `src = ./.` instances with more explicit source listings. Otherwise, derivations will be rebuilt on any change to the files defining them (e.g. formatting via nixfmt-rfc-style).
github-actions
bot
added
the
6.topic: rust
ofborg
bot
added
10.rebuild-darwin: 0
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace
src = ./.instances with more explicit source listings usinglib.fileset. Otherwise, derivations will be rebuilt on any change to the files defining them (e.g. formatting via nixfmt-rfc-style).Related: #301014
Quick testing instructions:
nix-build -A tests.importCargoLock(run relevant tests)nix run nixpkgs#nixfmt-rfc-style -- pkgs/build-support/rust/test/import-cargo-lock/(two source files should be reformatted)nix-build -A tests.importCargoLock(attempt to re-run tests, noticing that the reformatting has not caused any tests to actually be rebuilt)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.