doc/gnome: make wrapGAppsHook4 more discoverable#302599
Merged
DanielSidhion merged 1 commit intoNixOS:masterfrom Apr 13, 2024
Merged
doc/gnome: make wrapGAppsHook4 more discoverable#302599DanielSidhion merged 1 commit intoNixOS:masterfrom
DanielSidhion merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: GNOME
jtojnar
reviewed
Apr 8, 2024
Aleksanaa
force-pushed
the
doc-wrapGAppsHook4
branch
from
65a7999 to
9f90c73
Compare
ofborg
bot
added
10.rebuild-darwin: 0
Aleksanaa
changed the title
Member
Author
|
@ofborg eval |
Member
|
Thinking about it a bit more, maybe we should rename the Probably best wait after #291339 is merged, though, to reduce the conflicts. |
DanielSidhion
approved these changes
Apr 13, 2024
Member
DanielSidhion
left a comment
DanielSidhion
left a comment
There was a problem hiding this comment.
Given this is a very focused change in the docs to make it easier for users to understand what to use, I'm going ahead with merging it.
For the work mentioned to rename the function, I created an issue (already linked to this PR) so it can be done at an appropriate time.
I'm going ahead with merging this just so we don't block docs changes on that other work :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
A follow-up of #301865.
Also related: #227825
Previously wrapGAppsHook4 was sandwiched in the middle of a paragraph and only briefly described. I have restructured this paragraph.
In addition, I also mentioned gtk4-update-icon-cache to avoid potential problems caused by introducing gtk3 in the gtk4 package.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.