Skip to content

ceph: pin to cython_0#302358

Merged
mweinelt merged 2 commits intoNixOS:staging-nextfrom
danielbarter:ceph-cython-fix
Apr 18, 2024
Merged

ceph: pin to cython_0#302358
mweinelt merged 2 commits intoNixOS:staging-nextfrom
danielbarter:ceph-cython-fix

Conversation

@danielbarter
Copy link
Contributor

@danielbarter danielbarter commented Apr 7, 2024

Description of changes

Downgrading cython since ceph does not build with cython v3. Fixes #302224

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from adevress April 7, 2024 15:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2024
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 11, 2024
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 11, 2024
@mweinelt
Copy link
Member

Ceph is cached for me on master. Is this still relevant?

@danielbarter
Copy link
Contributor Author

danielbarter commented Apr 18, 2024

@mweinelt: just checked, and still seeing the same error on staging-next, so probably gonna be hitting master in the next few days

@mweinelt mweinelt marked this pull request as draft April 18, 2024 09:07
@mweinelt mweinelt changed the base branch from staging to staging-next April 18, 2024 09:07
@mweinelt mweinelt marked this pull request as ready for review April 18, 2024 09:08
@mweinelt mweinelt changed the title ceph: build broken with cython v3 ceph: pin to cython_0 Apr 18, 2024
@mweinelt mweinelt merged commit 40b1df8 into NixOS:staging-next Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants