haskellPackages.zip: Don't check#302306
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Apr 7, 2024
Merged
Conversation
mpscholten
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
|
Seems okay, as the archives seem to be randomly generated in the test suite (can you try to confirm?). Override needs to be exclusive to darwin, so |
ofborg
bot
added
10.rebuild-darwin: 1-10
Tests fail on macOS right now mrkkrp/zip#112
Contributor
Author
|
Yes that makes sense 👍 I guess upstream could fix this eventually by only generating path names that are valid on macOS. Just moved it to |
ofborg
bot
added
10.rebuild-linux: 0
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests fail on macOS right now
mrkkrp/zip#112
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.