Skip to content

tvheadend: Add additional network params.#302304

Open
pyle wants to merge 2 commits intoNixOS:masterfrom
pyle:tvheadend-options
Open

tvheadend: Add additional network params.#302304
pyle wants to merge 2 commits intoNixOS:masterfrom
pyle:tvheadend-options

Conversation

@pyle
Copy link
Contributor

@pyle pyle commented Apr 7, 2024

Initially i was just going to add ipv6 options as thats what i needed. I ended up giving this module a birthday as well.

Outline of changes:

  • Add options for ipv6 and bindAddr
  • Add configurable user/group/package
  • Update systemd service (docs/cfg options)
  • Ran nixfmt over file

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 7, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Apr 7, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 7, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 3, 2024
pyle added 2 commits May 25, 2024 19:26
Initially i was just going to add ipv6 options as thats what i needed. I ended up giving this module a birthday as well.

Outline of changes:

- Add options for ipv6 and bindAddr
- Add configurable user/group/package
- Update systemd service (docs/cfg options)
- Ran `nixfmt` over file
@pyle pyle force-pushed the tvheadend-options branch from 1ae1d10 to c15c581 Compare May 25, 2024 09:26
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 25, 2024
@emilazy
Copy link
Member

emilazy commented Aug 21, 2024

Thank you for your contribution! I’m linking #332259 and #336395 here for anyone interested in this PR, as we need to figure out what to do about this package and module.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants