haskellPackages.currencies: Unbroken#302302
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Apr 8, 2024
Merged
Conversation
mpscholten
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Could you maybe link an upstream issue or add some information (or even an assert) on when this jailbreak can be removed? Otherwise we just accumulate more and more overrides without knowing if they are needed. |
The build is broken because the package hasn't been updated for text >= 2 yet
mpscholten
force-pushed
the
fix-currencies
branch
from
b975c30 to
4fd42c8
Compare
Contributor
Author
|
👍 just created a fix PR at alx741/currencies#3 and added a comment to that PR |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build is broken because the package hasn't been updated for text >= 2 yet
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.