knot-resolver: re-enable http module#301747
Merged
flokli merged 2 commits intoNixOS:stagingfrom Apr 5, 2024
Merged
Conversation
This reverts commit 11fd363. The underlying issue has been fixed in https://github.com/NixOS/nixpkgs/pull/300905/files, this workaround is not needed anymore.
This reverts commit 4cad050. The underlying issue has been fixed in https://github.com/NixOS/nixpkgs/pull/300905/files, this workaround is not needed anymore.
13 tasks
vcunat
approved these changes
Apr 5, 2024
Member
vcunat
left a comment
vcunat
left a comment
There was a problem hiding this comment.
Sounds good, especially if you tested it.
Member
Author
|
I verified it built, which previously failed. I didn't run it (and there's no VM test to execute either), but considering #286822 added a (passing) test for lua http module imports and that the knot-resolver tests can now import it, it's probably safe to assume it should work :-) |
ofborg
bot
added
10.rebuild-darwin: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The reverts 4cad050 and 11fd363.
The proper fix (#286822) has been merged, this isn't necessary anymore, and brings back prometheus metrics (#300905 (comment)).
I successfully built
knot-resolverwith this again (but reverted another stdenv rebuild locally to avoid some more rebuilds.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.