lua.tests.checkSetupHook: test lua setup hook for http package#300905
lua.tests.checkSetupHook: test lua setup hook for http package#300905flokli merged 2 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: lua
ofborg
bot
added
10.rebuild-darwin: 501+
github-actions
bot
added
the
6.topic: python
the 'http' package is an interesting one to test because all its lua files are in a 'http' subfolder, ie., there is no share/lua/5.1/*.lua, only share/lua/5.1/http/*.lua files unlike most packages. This tests we can match those subfolders.
the setup-hook checks if a derivation contains lua files matching lua_path patterns. We use bash's globstar extension for that but `**.lua` doesn't return files in subfolders, it has to be `**/*.lua`. Adjust the pattern accordingly.
teto
force-pushed
the
teto/fix-lua-setup-hook
branch
from
37f5aca to
c55b4db
Compare
github-actions
bot
removed
the
6.topic: python
|
LGTM too. Also successfully built Let's land this. I'll leave it up to @vcunat to possibly cherrypick this into |
|
That iteration of staging-next is in master already, and knot-resolver got a workaround that at least lets you use it without |
|
I certainly planned that, though maybe a bit later. |
I've also run into this. I think the most common usecase for the http module is the prometheus metrics. |
|
Ah, right. Perhaps I forgot because mentally I'm in 6.x where it's not needed for prometheus. I should soon think about (NixOS) strategy for migration to 6.x, too. |
|
I opened #301747, which re-enables the http module for knot-resolver (targeting staging, as the fix is only on staging too). PTAL. |
|
|
5 participants
Fixes #286822 (comment)
the 'http' package is an interesting one to test because all its lua
files are in a 'http' subfolder, ie., there is no share/lua/5.1/.lua,
only share/lua/5.1/http/.lua files unlike most packages. This tests we
can match those subfolders.
Will retarget against staging before merge
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.