Skip to content

[staging-next] Fix python312Packages.django_{4,5} on aarch64-linux#300767

Merged
mweinelt merged 3 commits intoNixOS:staging-nextfrom
mweinelt:django-py312-aarch64-linux
Apr 1, 2024
Merged

[staging-next] Fix python312Packages.django_{4,5} on aarch64-linux#300767
mweinelt merged 3 commits intoNixOS:staging-nextfrom
mweinelt:django-py312-aarch64-linux

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Apr 1, 2024

This reverts commit f8b4e28.

We're instead disabling the failing test on the django derivation.

cc #298548

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 1, 2024
mweinelt added 3 commits April 1, 2024 21:14
This reverts commit f8b4e28.

We're instead disabling the failing test on the django derivation.
With the revert of xz 5.4.6 (down from 5.6.0) this test started failing
on aarch64-linux on Python 3.12.
With the revert of xz 5.4.6 (down from 5.6.0) this test started failing
on aarch64-linux on Python 3.12.
@mweinelt mweinelt force-pushed the django-py312-aarch64-linux branch from ea248f4 to dc9aaed Compare April 1, 2024 19:15
@vcunat
Copy link
Member

vcunat commented Apr 1, 2024

@ofborg eval
@ofborg build python312Packages.django_4 python312Packages.django_5

@vcunat
Copy link
Member

vcunat commented Apr 1, 2024

OfBorg says that it doesn't build.

@mweinelt
Copy link
Member Author

mweinelt commented Apr 1, 2024

That's probably a race condition, won't fix for now.

@mweinelt
Copy link
Member Author

mweinelt commented Apr 1, 2024

@ofborg build python312Packages.django_4
@ofborg build python312Packages.django_5

@mweinelt mweinelt merged commit 2373d86 into NixOS:staging-next Apr 1, 2024
@mweinelt mweinelt deleted the django-py312-aarch64-linux branch April 1, 2024 20:27
@ofborg ofborg bot requested review from Mic92 and fabaff April 1, 2024 20:43
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants