nixos-rebuild: use substitute rather than substituteAll#300308
Merged
roberth merged 1 commit intoNixOS:masterfrom Mar 30, 2024
Merged
nixos-rebuild: use substitute rather than substituteAll#300308roberth merged 1 commit intoNixOS:masterfrom
substitute rather than substituteAll#300308roberth merged 1 commit intoNixOS:masterfrom
Conversation
No change in produced output.
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
This is similar to 193f4fe. |
roberth
approved these changes
Mar 30, 2024
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
- ✔️ No other variables captured in the script template. Checked with regex
@[a-zA-Z]. - ✔️ Tests pass
Member
|
Thanks! |
This was referenced Mar 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
There's no change in produced output, though this does rebuild the script. Rationale is here:
substituteAllis a terrible function and we need to stop using it / fix it respectively #237216Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)