Skip to content

Revert #294347 (and #300177)#300247

Merged
K900 merged 2 commits intoNixOS:masterfrom
K900:revert-294347-etc
Mar 30, 2024
Merged

Revert #294347 (and #300177)#300247
K900 merged 2 commits intoNixOS:masterfrom
K900:revert-294347-etc

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Mar 30, 2024

Description of changes

Broke eval, backing out.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 K900 requested review from adisbladis and lolbinarycat March 30, 2024 14:20
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: stdenv Standard environment labels Mar 30, 2024
@K900 K900 mentioned this pull request Mar 30, 2024
13 tasks
@K900 K900 merged commit 42b1ad9 into NixOS:master Mar 30, 2024
@ghost
Copy link

ghost commented Mar 30, 2024

thanks

@K900 K900 deleted the revert-294347-etc branch July 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant