papers: init at 45.0-unstable-2024-03-27#299579
Conversation
|
Thanks for taking the initiative! We don't really add new packages to the gnome space anymore - this should go into |
Thanks for your feedback, I've fixed these problems with today's latest commit. Please say to me if it is good now |
|
It should be the last published tag preceding the commit to keep the version monotonically increasing.
…On Tue, 2 Apr 2024, 16:37 Jo-Blade, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/by-name/pa/papers/package.nix
<#299579 (comment)>:
> +, dbus
+, gst_all_1
+, gi-docgen
+, supportMultimedia ? true # PDF multimedia
+, libgxps
+, supportXPS ? true # Open XML Paper Specification via libgxps
+, withLibsecret ? true
+, libadwaita
+, exempi
+, cargo
+, rustPlatform
+}:
+
+stdenv.mkDerivation rec {
+ pname = "papers";
+ version = "unstable-2024-3-27";
Why 45 rather than 46 ?
—
Reply to this email directly, view it on GitHub
<#299579 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMEY5DPFOHIE4RYI3BOYLY3K7DRAVCNFSM6AAAAABFLS2FQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNZUGAZTOMRUGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Can you clean up the history especially squash the review commits? @ofborg eval |
Of course ! Just done it now |
|
@Jo-Blade I think with all the fixups, the correct commit message is now Thanks for doing this work! |
You're totally right ! I just updated it now ;) |
|
Result of 3 packages built:
|
Description of changes
Initial package for Papers : https://gitlab.gnome.org/GNOME/Incubator/papers
This is a replacement of the evince pdf viewer with a new GTK4/Libadwaita UI written in rust.
This was proposed as "good to have" in the next gnome-46 release, see #291339
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.