Skip to content

[23.11] Backport #298535: graphicsmagick: 1.3.39 -> 1.3.43#299388

Merged
drupol merged 8 commits intoNixOS:release-23.11from
atorres1985-contrib:backport-graphicsmagick-to-2311
Mar 27, 2024
Merged

[23.11] Backport #298535: graphicsmagick: 1.3.39 -> 1.3.43#299388
drupol merged 8 commits intoNixOS:release-23.11from
atorres1985-contrib:backport-graphicsmagick-to-2311

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Mar 27, 2024

Description of changes

Backports #298535

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres requested a review from drupol March 27, 2024 03:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Mar 27, 2024
@AndersonTorres
Copy link
Member Author

Yay, we need to backport graphviz too!

AndersonTorres and others added 8 commits March 27, 2024 12:13
- finalAttrs design pattern
- split man output
- rename patches
- update link that explains the patch

(cherry picked from commit 1bde615)
- use stdenvNoCC (since no compiler is called)
- split man output
- do not expose attributes
- set `dontBuild = true` instead of using a fake `buildPhase`
- install the artifacts via an elegant but questionable, Lispy dark magic

(cherry picked from commit 7bfecb7)
(cherry picked from commit cdf0640)
Co-authored-by: R. Ryantm <[email protected]>
(cherry picked from commit 08d1d84)
Since the security breach was solved upstream.

(cherry picked from commit dd65942)
It requires a file that does not exist yet.
@AndersonTorres AndersonTorres marked this pull request as ready for review March 27, 2024 17:01
@AndersonTorres
Copy link
Member Author

Forget the test.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 27, 2024
@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 27, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1558

@drupol drupol merged commit cbda9ba into NixOS:release-23.11 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants