Skip to content

haskellPackages.string-random: jailbreak on ghc9.8#299122

Merged
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:string-random
Mar 26, 2024
Merged

haskellPackages.string-random: jailbreak on ghc9.8#299122
ncfavier merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:string-random

Conversation

@mpscholten
Copy link
Contributor

Description of changes

Package is broken on GHC 9.8 due to text constraints

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Mar 26, 2024
@drupol drupol changed the title jailbreak string-random haskellPackages.string-random: jailbreak on ghc9.8 Mar 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 26, 2024
@ncfavier
Copy link
Member

The commit message should start with haskell.packages.ghc98.string-random since this is only touching the package on GHC 9.8

@mpscholten
Copy link
Contributor Author

Good point, fixed, will also fix the other PRs

@ncfavier ncfavier merged commit 3d3fe7d into NixOS:haskell-updates Mar 26, 2024
@mpscholten mpscholten deleted the string-random branch March 26, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants