graphicsmagick: 1.3.42 -> 1.3.43#298535
Merged
drupol merged 7 commits intoNixOS:masterfrom Mar 25, 2024
atorres1985-contrib:graphicsmagick
Merged
graphicsmagick: 1.3.42 -> 1.3.43#298535drupol merged 7 commits intoNixOS:masterfrom atorres1985-contrib:graphicsmagick
drupol merged 7 commits intoNixOS:masterfrom
atorres1985-contrib:graphicsmagick
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
ofborg
bot
added
11.by: package-maintainer
drupol
requested changes
Mar 24, 2024
thiagokokada
approved these changes
Mar 25, 2024
drupol
reviewed
Mar 25, 2024
wegank
added
the
12.approvals: 1
drupol
added
the
1.severity: security
wegank
removed
the
12.approvals: 1
thiagokokada
approved these changes
Mar 25, 2024
- finalAttrs design pattern - split man output - rename patches - update link that explains the patch
- use stdenvNoCC (since no compiler is called) - split man output - do not expose attributes - set `dontBuild = true` instead of using a fake `buildPhase` - install the artifacts via an elegant but questionable, Lispy dark magic
Co-authored-by: R. Ryantm <[email protected]>
Since the security breach was solved upstream.
thiagokokada
approved these changes
Mar 25, 2024
drupol
approved these changes
Mar 25, 2024
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-298535-to-release-23.11 origin/release-23.11
cd .worktree/backport-298535-to-release-23.11
git switch --create backport-298535-to-release-23.11
git cherry-pick -x 1bde61517c73e3cdaee47ca351de657e545b353b 8b908e4babf6856f2f174b647bbf8b283d3abfb3 94723d06510339297c84acc39abe4b4e4704522a 7bfecb71e37a0ca6a722ed9117ca0b09517c0cdd cdf0640f87de7c94d172bcc6923e0e53bfb6e61b 08d1d8496cafebdbc3bdd002cea287d6f25696d8 dd65942c9a5a6d1904645b7770a862576d8a0997 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-23.11
git worktree add -d .worktree/backport-298535-to-release-23.11 origin/release-23.11
cd .worktree/backport-298535-to-release-23.11
git switch --create backport-298535-to-release-23.11
git cherry-pick -x 1bde61517c73e3cdaee47ca351de657e545b353b 8b908e4babf6856f2f174b647bbf8b283d3abfb3 94723d06510339297c84acc39abe4b4e4704522a 7bfecb71e37a0ca6a722ed9117ca0b09517c0cdd cdf0640f87de7c94d172bcc6923e0e53bfb6e61b 08d1d8496cafebdbc3bdd002cea287d6f25696d8 dd65942c9a5a6d1904645b7770a862576d8a0997 |
Contributor
|
@AndersonTorres Do you plan to backport it? |
Member
Author
|
Since the bot refused and this is a security issue, I will do this later. |
Contributor
|
I thank your effort. |
13 tasks
drupol
added a commit
that referenced
this pull request
Mar 27, 2024
…magick-to-2311 [23.11] Backport #298535: graphicsmagick: 1.3.39 -> 1.3.43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #298523
Updated, modernized and adopted!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.