Skip to content

cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1#298340

Merged
Ma27 merged 2 commits intoNixOS:stagingfrom
alyssais:rust-1.77.0
Apr 10, 2024
Merged

cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1#298340
Ma27 merged 2 commits intoNixOS:stagingfrom
alyssais:rust-1.77.0

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Mar 23, 2024 •
edited
Loading

Description of changes

Tested fd on aarch64-linux, and firefox, thunderbird, and fd on x86_64-linux.

Still looking for somebody to test fd on x86_64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Mar 23, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 23, 2024
@zowoq
Copy link
Contributor

zowoq commented Mar 24, 2024

Build fd on x86_64-darwin.

@alyssais alyssais requested a review from RaitoBezarius as a code owner March 24, 2024 11:29
@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Mar 24, 2024
@alyssais alyssais force-pushed the rust-1.77.0 branch 3 times, most recently from 5868204 to b5988d5 Compare March 27, 2024 15:06
@alyssais alyssais requested a review from blitz March 27, 2024 15:16
@workingjubilee workingjubilee mentioned this pull request Mar 27, 2024
Open
@workingjubilee
Copy link

workingjubilee commented Mar 27, 2024 •
edited
Loading

you may wish to be aware of #299606 but it is non-blocking I think, since it seems to require other variables to be involved in order to mess things up, and may not necessarily be considered a problem for ordinary use of nixpkgs.

also we're doing a point release tomorrow to fix a related bug, but only for Windows: rust-lang/rust#122857 but maybe that matters for cross-compiling, idk.

relevant original blog post explaining the motivation: https://kobzol.github.io/rust/cargo/2024/01/23/making-rust-binaries-smaller-by-default.html

@sdht0
Copy link
Contributor

sdht0 commented Mar 31, 2024

https://blog.rust-lang.org/2024/03/28/Rust-1.77.1.html is out

@winterqt
Copy link
Member

winterqt commented Mar 31, 2024

Probably fine just to skip that point release, given it only affects MSVC?

@rcrowe rcrowe mentioned this pull request Mar 31, 2024
Closed
14 tasks
@sdht0
Copy link
Contributor

sdht0 commented Mar 31, 2024

Probably fine just to skip that point release, given it only affects MSVC?

Practically yes. OTOH repology will show the nixpkgs version to be outdated until the next release, for instance. Fine either ways.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 31, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 1, 2024
@marsam marsam mentioned this pull request Apr 3, 2024
Closed
1 task
@alyssais alyssais changed the title cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.0 cargo,clippy,rustc,rustfmt: 1.76.0 -> 1.77.1 Apr 3, 2024
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Apr 4, 2024
@roblabla roblabla mentioned this pull request Apr 4, 2024
Closed
13 tasks
@link2xt link2xt mentioned this pull request Apr 4, 2024
Closed
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 5, 2024
Ma27
Ma27 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Requires a rebase, but other than that it looks good to me 👍

@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Apr 6, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 8, 2024
@ofborg ofborg bot requested a review from Ma27 April 8, 2024 17:36
@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Apr 9, 2024
JohnRTitor
JohnRTitor approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be merged now?

@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Apr 9, 2024
@Ma27 Ma27 merged commit 936c4d7 into NixOS:staging Apr 10, 2024
link2xt added a commit to chatmail/core that referenced this pull request Apr 10, 2024
@link2xt
build: nix flake update
51314c9 
Update to Rust 1.77 since
<NixOS/nixpkgs#298340>
is merged.
@link2xt link2xt mentioned this pull request Apr 10, 2024
Closed
@phaer phaer mentioned this pull request Apr 12, 2024
Closed
13 tasks
@alyssais alyssais deleted the rust-1.77.0 branch May 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phaer phaer phaer approved these changes

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

@figsoda figsoda Awaiting requested review from figsoda

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@TredwellGit TredwellGit Awaiting requested review from TredwellGit

@Ma27 Ma27 Awaiting requested review from Ma27

+1 more reviewer

@blitz blitz blitz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: kernel The Linux kernel 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@alyssais @zowoq @workingjubilee @sdht0 @winterqt @blitz @phaer @Ma27 @JohnRTitor @wegank