systemd: remote journal requires gnutls to accept --trust#297870
Closed
r-vdp wants to merge 2 commits intoNixOS:stagingfrom
Closed
systemd: remote journal requires gnutls to accept --trust#297870r-vdp wants to merge 2 commits intoNixOS:stagingfrom
--trust#297870r-vdp wants to merge 2 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
6.topic: nixos
13 tasks
ofborg
bot
added
10.rebuild-darwin: 101-500
github-actions
bot
added
the
8.has: module (update)
The systemd-journal-gatewayd test fails because of this. See https://github.com/systemd/systemd/blob/ec0bc263d7d250d4029e8ffe7e3a888c12453331/src/journal-remote/journal-gatewayd.c#L1046-L1062 An alternative would be to either introduce a new option to selectively enable gnutls for those who need it (and for our VM test), but that's also not great in terms of discoverability.
…file system permissions
r-vdp
force-pushed
the
systemd-remote-journal-gnutls
branch
from
789982d to
09065c5
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
Member
|
urgh I really don't want to link systemd with gnutls. I want upstream to fix the migration to openssl for all component instead. |
Member
|
@arianvp is there already an upstream issue about it? Maybe we can link to here for context. |
Member
|
I just stumbled upon this too. I think we should definitely have an upstream issue about this. |
Contributor
I like this. I would not have thought that |
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The systemd-journal-gatewayd test fails because of this.
See https://github.com/systemd/systemd/blob/ec0bc263d7d250d4029e8ffe7e3a888c12453331/src/journal-remote/journal-gatewayd.c#L1046-L1062
An alternative would be to either introduce a new option to selectively enable gnutls for those who need it (and for our VM test), but that's also not great in terms of discoverability.
I added a second commit to use
LoadCredentialsto make the secrets available to the service instead of needing to set file system permissions to give access to thesystemd-journal-gatewayuser. This might also in the future allow us to setDynamicUser = truefor this service.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.