try to fix ca-derivations firefox#297466
Merged
mweinelt merged 2 commits intoNixOS:masterfrom Mar 20, 2024
Merged
Conversation
NixOSInfra
added
the
12.first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
mweinelt
reviewed
Mar 20, 2024
Co-authored-by: Martin Weinelt <[email protected]>
Member
|
@ofborg test firefox |
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Oct 21, 2024
see analog example of this fix in firefox in NixOS#297466 Signed-off-by: Florian Brandes <[email protected]>
13 tasks
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Oct 21, 2024
see analog example of this fix in firefox in NixOS#297466 Signed-off-by: Florian Brandes <[email protected]>
gador
added a commit
to gador/nixpkgs
that referenced
this pull request
Oct 21, 2024
see analog example of this fix in firefox in NixOS#297466 Signed-off-by: Florian Brandes <[email protected]>
keatonhasse
pushed a commit
to keatonhasse/nixpkgs
that referenced
this pull request
Oct 30, 2024
see analog example of this fix in firefox in NixOS#297466 Signed-off-by: Florian Brandes <[email protected]>
This was referenced Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed illegal reference in derivation, resolves #297423
Things done
found a reference to stdenv.cc, removed it with removeReferencesTo, based on other PRs that did a similar fixup
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.